tabish121 commented on code in PR #4484: URL: https://github.com/apache/activemq-artemis/pull/4484#discussion_r1198305231
########## docs/user-manual/en/undelivered-messages.md: ########## @@ -31,6 +31,12 @@ fail or rollback. Without a delayed redelivery, the system can get into a and delivery being re-attempted ad infinitum in quick succession, consuming valuable CPU and network resources. +#Persist Redelivery + +Two Journal update records are stored every time a redelivery happens. One for the number of deliveries that happened, and one in case a scheduled redelivery is being used. +It is recommended to keep persist-redelivery=false as if you are playing with very short redeliveries you may create unecessary records on the journal. Review Comment: Reworded a bit and changed to 'redelivery delays' as long / short redeliveries doesn't really convey logical meaning "It is recommended to keep persist-redelivery=false in situations where you are operating with very short redelivery delays as you will be creating unecessary records on the journal." ########## docs/user-manual/en/configuration-index.md: ########## @@ -210,6 +210,7 @@ name | node name; used in topology notifications if set. | n/a [read-whole-page](paging.md) | If true the whole page would be read, otherwise just seek and read while getting message. | `false` [paging-directory](paging.md#configuration)| the directory to store paged messages in. | `data/paging` [persist-delivery-count-before-delivery](undelivered-messages.md#delivery-count-persistence) | True means that the delivery count is persisted before delivery. False means that this only happens after a message has been cancelled. | `false` +[persist-redelivery](undelivered-messages.md#persist-redelivery) | True means that a journal update record is added every time a redelivery occurs. If your system is playing with short redeliveries this should be set to false (recommended value). | `true` Review Comment: The term 'short redeliveries' doesn't really read well to me, seems more accurate to write it as 'short redelivery delays' based on what I think you mean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
