tabish121 commented on code in PR #4484:
URL: https://github.com/apache/activemq-artemis/pull/4484#discussion_r1199182684
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java:
##########
@@ -249,7 +249,7 @@ public static String getDefaultHapolicyBackupStrategy() {
private static boolean DEFAULT_PERSIST_DELIVERY_COUNT_BEFORE_DELIVERY =
false;
// True means that we will persist redelivery on the journal
Review Comment:
This comment seems outdated now
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java:
##########
@@ -139,12 +139,15 @@ public interface Configuration {
Configuration setPersistenceEnabled(boolean enable);
/**
- * Sets when redeliveries are persisted or not.
- * This will control if the delivery counter and redelivery delay should be
persisted.
+ * Maximum number of redelivery records stored on the journal per message
reference.
*/
- Configuration setPersistRedelivery(boolean enable);
+ Configuration setMaxRedeliveryRecords(int maxPersistRedelivery);
- boolean isPersistRedelivery();
+ /**
+ * Maximum number of redelivery reco
Review Comment:
seems like the sentence died abruptly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
