gemmellr commented on code in PR #4544:
URL: https://github.com/apache/activemq-artemis/pull/4544#discussion_r1259848820
##########
artemis-quorum-ri/pom.xml:
##########
@@ -43,6 +47,12 @@
<dependency>
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
+ <scope>test</scope>
Review Comment:
Also not sure about this one changing to test. The main purpose of this
module is currently to use ZK. That it does it via the curator stuff doesnt
really mean this is a test-only dep, whilst listing it like this really makes
it seem like it is...however anything using this module will still get ZK since
it isnt really. Maven doesnt have a way of saying "runtime + test" which is
what this really is. I think I'd leave it at compile for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
