gemmellr commented on code in PR #4544:
URL: https://github.com/apache/activemq-artemis/pull/4544#discussion_r1260955912
##########
artemis-junit/artemis-junit-5/pom.xml:
##########
@@ -57,12 +57,7 @@
</dependency>
<dependency>
<groupId>org.apache.activemq</groupId>
- <artifactId>artemis-jms-server</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.activemq</groupId>
- <artifactId>artemis-jms-client</artifactId>
Review Comment:
I was 'ok' with this removal since the junit 5 stuff is actually 'core
centric' (which again, I dont actually think makes any sense, since we would
recommend the JMS client to most, and most I've seen using this want it to test
with the JMS client, so they typically shouldn't be using the core API directly
for anything).
Thats unlike the original junit 4 aimed stuff though, which has some very
JMS-specific bits as well, that do use the JMS client, so I dont think it
should be removed from the junit 4 stuff at this point since that has always
supplied the JMS client, and some will expect it to.
I have however been forgetting about junit-commons module also existing,
which is perhaps still supplying the jms client to _both_ the junit 4 and 5
modules (the latter should arguably be excluding it if so) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
