gtully commented on code in PR #4552:
URL: https://github.com/apache/activemq-artemis/pull/4552#discussion_r1262329262


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java:
##########
@@ -1584,4 +1584,7 @@ void slowConsumerDetected(String sessionID,
 
    @LogMessage(id = 224126, value = "Failure during protocol handshake on 
connection to {} from {}", level = LogMessage.Level.ERROR)
    void failureDuringProtocolHandshake(SocketAddress localAddress, 
SocketAddress remoteAddress, Throwable e);
+
+   @LogMessage(id = 224127, value = "Queue {}/Address {} is currently 
delivering {} messages that are holding {} bytes, with max reading sizes 
configured as addressSettings.maxPageReadMessages={} and 
addressSettings.maxPageReadBytes={}. System will not read more data from paging 
until acks are made. You can increase the address settings page-max-read 
attributes or make sure your consumers use lower batch sizes.", level = 
LogMessage.Level.WARN)

Review Comment:
   it is only reading to dispatch, from a user perspective, dispatch is 
blocked. it is transient, but for a new consumer on a queue with pending 
messages, that is the disconnect that we want to fill with the logging.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to