clebertsuconic commented on code in PR #4552:
URL: https://github.com/apache/activemq-artemis/pull/4552#discussion_r1262384468


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -179,6 +179,14 @@ public class QueueImpl extends CriticalComponentImpl 
implements Queue {
 
    private volatile boolean queueDestroyed = false;
 
+   // Variable to control if we should print a flow controlled message or not.
+   // Once it was flow controlled, we will stop warning until it's cleared 
once again
+   private volatile boolean pageFlowControlled = false;
+
+   private volatile long pageFlowControlledLastLog = 0;
+
+   private static final long PAGE_FLOW_CONTROL_PRINT_INTERVAL = 60_000L;

Review Comment:
   I was trying to avoid another configuration attribute in broker.xml.
   
   the system will always try to depage when a new consumer is added.. yeah.
   
   Reason I made it WARN was : first I was in doubt which level I should 
use.... as I talked to a few users they usually ignore anything bellow WARN and 
will only get notifications when WARN is used. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to