jbertram commented on code in PR #4545:
URL: https://github.com/apache/activemq-artemis/pull/4545#discussion_r1268235641
##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/common/SmokeTestBase.java:
##########
@@ -158,24 +156,6 @@ protected static final void recreateBrokerDirectory(final
String homeInstance) {
recreateDirectory(homeInstance + "/log");
}
-
- public boolean waitForServerToStart(String uri, String username, String
password, long timeout) throws InterruptedException {
- long realTimeout = System.currentTimeMillis() + timeout;
- while (System.currentTimeMillis() < realTimeout) {
- try (ActiveMQConnectionFactory cf =
ActiveMQJMSClient.createConnectionFactory(uri, null)) {
- cf.createConnection(username, password).close();
- System.out.println("server " + uri + " started");
- } catch (Exception e) {
- System.out.println("awaiting server " + uri + " start at ");
- Thread.sleep(500);
- continue;
- }
- return true;
- }
-
- return false;
- }
-
Review Comment:
Is this change actually related to the ZooKeep & Curator upgrade? It looks
like an unrelated removal of an unused method.
##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/common/SmokeTestBase.java:
##########
@@ -158,24 +156,6 @@ protected static final void recreateBrokerDirectory(final
String homeInstance) {
recreateDirectory(homeInstance + "/log");
}
-
- public boolean waitForServerToStart(String uri, String username, String
password, long timeout) throws InterruptedException {
- long realTimeout = System.currentTimeMillis() + timeout;
- while (System.currentTimeMillis() < realTimeout) {
- try (ActiveMQConnectionFactory cf =
ActiveMQJMSClient.createConnectionFactory(uri, null)) {
- cf.createConnection(username, password).close();
- System.out.println("server " + uri + " started");
- } catch (Exception e) {
- System.out.println("awaiting server " + uri + " start at ");
- Thread.sleep(500);
- continue;
- }
- return true;
- }
-
- return false;
- }
-
Review Comment:
Is this change actually related to the ZooKeeper & Curator upgrade? It looks
like an unrelated removal of an unused method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
