jbertram commented on code in PR #4545:
URL: https://github.com/apache/activemq-artemis/pull/4545#discussion_r1268296418
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ssl/CoreClientOverOneWaySSLTest.java:
##########
@@ -85,9 +85,9 @@ public static Collection getParameters() {
{"SunJCE", "JCEKS", false, false},
{"SUN", "JKS", false, false},
{"SunJSSE", "PKCS12", false, false},
- {"JCEKS", null, true, false}, // for compatibility with old
keyStoreProvider
- {"JKS", null, true, false}, // for compatibility with old
keyStoreProvider
- {"PKCS12", null, true, false} // for compatibility with old
keyStoreProvider
+ {"JCEKS", null, false, false}, // for compatibility with old
keyStoreProvider
+ {"JKS", null, false, false}, // for compatibility with old
keyStoreProvider
+ {"PKCS12", null, false, false} // for compatibility with old
keyStoreProvider
Review Comment:
I took a look at the ZooKeeper code. As far as I can tell it's using SLF4J
as the API (just like the broker), and Logback is the implementation. I think
you'd be fine to exclude Logback via the `pom.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
