fartzy commented on code in PR #4569:
URL: https://github.com/apache/activemq-artemis/pull/4569#discussion_r1275524971


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1797,6 +1817,8 @@ public void encode(ActiveMQBuffer buffer) {
 
       BufferHelper.writeNullableLong(buffer, pageLimitMessages);
 
+      BufferHelper.writeNullableInteger(buffer, idCacheSize);

Review Comment:
   oh yeah it will definitely get mixed up with currently persisted messages - 
thanks. I put both the read and write at end now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to