fartzy commented on code in PR #4569:
URL: https://github.com/apache/activemq-artemis/pull/4569#discussion_r1283794559
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java:
##########
@@ -1456,6 +1458,10 @@ protected Pair<String, AddressSettings>
parseAddressSettings(final Node node) {
addressSettings.setEnableMetrics(XMLUtil.parseBoolean(child));
} else if (ENABLE_INGRESS_TIMESTAMP.equalsIgnoreCase(name)) {
addressSettings.setEnableIngressTimestamp(XMLUtil.parseBoolean(child));
+ } else if (ID_CACHE_SIZE.equalsIgnoreCase(name)) {
+ int idCacheSize = XMLUtil.parseInt(child);
+ Validators.GT_ZERO.validate(ID_CACHE_SIZE, idCacheSize);
Review Comment:
Yeah makes sense! changed to `Validators.GE_ZERO`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
