gemmellr commented on code in PR #4602:
URL: https://github.com/apache/activemq-artemis/pull/4602#discussion_r1313196744
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/LVQTest.java:
##########
@@ -167,11 +167,13 @@ public void testMultipleMessages() throws Exception {
ClientMessage m = consumer.receive(1000);
Assert.assertNotNull(m);
m.acknowledge();
- Assert.assertEquals(m.getBodyBuffer().readString(), "m3");
+ String val = m.getBodyBuffer().readString();
+ Assert.assertTrue("1 or 3 =? " + val, "m1".equals(val) ||
"m3".equals(val));
Review Comment:
This doesnt seem like a desirable change for an LVQ test. It would then be
about as well deleted it for all the good it would really be doing in verifying
the 'LV' bit.
It currently creates the consumer before sending so it seems rather pot-luck
what it will see. The next test creates it after, and also checks the count as
you said. Or it could use a transacted producer for the 'second round' of
sends. Something synchronous between send and check, basically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
