clebertsuconic commented on code in PR #4602:
URL: https://github.com/apache/activemq-artemis/pull/4602#discussion_r1323269602


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/LVQTest.java:
##########
@@ -167,11 +167,13 @@ public void testMultipleMessages() throws Exception {
       ClientMessage m = consumer.receive(1000);
       Assert.assertNotNull(m);
       m.acknowledge();
-      Assert.assertEquals(m.getBodyBuffer().readString(), "m3");
+      String val = m.getBodyBuffer().readString();
+      Assert.assertTrue("1 or 3 =? " + val, "m1".equals(val) || 
"m3".equals(val));

Review Comment:
   @gtully can't you instead make the test deterministic? like keeping 
consumers and senders on a certain condition that's required for the test?
   
   
   I had this issue in other tests... where I needed to verify the bindings 
were in place before asserting.. or the consumers were ready to receive with 
credits.. etc... 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to