clebertsuconic commented on code in PR #4619:
URL: https://github.com/apache/activemq-artemis/pull/4619#discussion_r1330500057
##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java:
##########
@@ -832,7 +863,16 @@ public AMQConnectionContext initContext(ConnectionInfo
info) throws Exception {
createInternalSession(info);
// the actor can only be used after the WireFormat has been initialized
with versioning
- this.openWireActor = new ThresholdActor<>(executor, this::act,
actorThresholdBytes, OpenWireConnection::getSize, this::disableAutoRead,
this::flushedActor);
+ this.openWireActor = new ThresholdActor<>(executor, this::act,
actorThresholdBytes, OpenWireConnection::getSize, this::disableAutoRead,
this::flushedActor) {
+ @Override
+ protected void doTask(Object task) {
Review Comment:
I would place this logic on ThresholdActor.
Set something when shutdown is called, and have the doTask checking if
(task==shutdownTask), it would do it right away.
The ThresholdActor is being done for OpenWire pretty much, and I think that
logic would apply to the super class anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
