clebertsuconic commented on code in PR #4619:
URL: https://github.com/apache/activemq-artemis/pull/4619#discussion_r1330500398
##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java:
##########
@@ -832,7 +863,16 @@ public AMQConnectionContext initContext(ConnectionInfo
info) throws Exception {
createInternalSession(info);
// the actor can only be used after the WireFormat has been initialized
with versioning
- this.openWireActor = new ThresholdActor<>(executor, this::act,
actorThresholdBytes, OpenWireConnection::getSize, this::disableAutoRead,
this::flushedActor);
+ this.openWireActor = new ThresholdActor<>(executor, this::act,
actorThresholdBytes, OpenWireConnection::getSize, this::disableAutoRead,
this::flushedActor) {
+ @Override
+ protected void doTask(Object task) {
Review Comment:
basically.. just keep doTask a final, and bring that logic up there. I think
it would be clearer that way!?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
