AntonRoskvist commented on code in PR #4659:
URL: https://github.com/apache/activemq-artemis/pull/4659#discussion_r1379061456
##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java:
##########
@@ -517,7 +517,6 @@ public void removeRolledback(MessageReference
messageReference) {
}
public void addRolledback(MessageReference messageReference) {
- currentWindow.decrementAndGet();
Review Comment:
It was a while since I looked at that, but I think this change will enable
the consumer to fetch messages past the prefetchLimit. It happens when doing
redeliveries, such that it can theoretically prefetch twice as many messages as
it's supposed to.
Again, saw this quite some time back so I could be mistaken...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
