gtully commented on code in PR #4659:
URL: https://github.com/apache/activemq-artemis/pull/4659#discussion_r1393018970
##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java:
##########
@@ -517,7 +517,6 @@ public void removeRolledback(MessageReference
messageReference) {
}
public void addRolledback(MessageReference messageReference) {
- currentWindow.decrementAndGet();
Review Comment:
@AntonRoskvist I pushed a new test that fails with a revert of line 520, the
decrement. I don't yet know what is at fault, but the root cause is the
combination of rolledback and delivered messages in a single transaction.
we decrement 11 times in stead of 1 if the session transaction is in play.
it may be that cancelRefs needs its own transaction all the time, the
comments at:
https://github.com/apache/activemq-artemis/blob/6e28e4683458490ab0e3990ba8f35e9c6531c461/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java#L2234
may have a hint - it speaks to the same problem.
it may be that cancleRefs should not have a tx at all, or a new one all the
time that has no IO may work ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
