brusdev commented on PR #4730: URL: https://github.com/apache/activemq-artemis/pull/4730#issuecomment-1880529377
> The design of the matching is to be hierarchical which is relatively easy to understand and configure with words separated by a delimiter and wildcards that represent one (i.e. * by default) or more (i.e. # by default) words. Partial words also would be hierarchical, I mean `*` would never match a delimiter. > Right now, `*` means **a single word**. If we start accepting "partial words" then what does `*` become? Is it a single word when used alone and then something else when used with a partial word? If the latter, is it any single _character_? Is it 0 or more of any character (e.g. as it might be in a regular expression)? My tentative was to implement the behavior similar to the `*` in the shells: matching zero or more characters but **not the delimiter** to respect the hierarchy. >Also, how do partial words compare to each other in a hierarchy where matches are ordered from general to specific? Would `ab*` be more specific than `a*` when matching `abc`? What about `a*c`? Is that even supported? Where do we draw the line? Good catch, I hadn't thought to this use case but if that would be supported then `a*c` would be more specific of `a*` > Furthermore, what do we do with `#`? Should we support partial matches with it? If so, what does that mean? If not, why not? Theoretically, `*` should be enough for any partial match use cases because `#` matches zero or more words. > The potential configurations start to expand very quickly and will no doubt add complication to the code, the test-suite, and the documentation. This is an important point from the development point of view, are you thinking to any specific cases? > If there's a bug here it's that undocumented behavior is allowed and somewhat functional leading folks to assume it's intentional. I'm not saying we should fix that necessarily, but we should at least consider it so we don't keep letting folks get confused. My tentative was to clarify this gray area without causing issues to users that are already using this **officially unsupported** behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
