gemmellr commented on code in PR #4730:
URL: https://github.com/apache/activemq-artemis/pull/4730#discussion_r1444910607
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/HierarchicalObjectRepository.java:
##########
@@ -477,50 +476,91 @@ default String modify(String input) {
/**
* Compares to matches to see which one is more specific.
+ * A match on the any-words delimiter (#) is considered less specific than
a match without it, i.e. abc.def.# is less specific than abc.def and abc.def
and abc.d*
Review Comment:
Either repetition or some other issue: "is less specific than abc.def and
abc.def"
##########
docs/user-manual/wildcard-syntax.adoc:
##########
@@ -31,9 +31,9 @@ But `news.europe.#` would _not_ match:
* `news.usa.sport`
* `entertainment`
-== Matching a Single Word
+== Matching a Single or Partial Word
-The character `*` means "match a single word".
+The character `*` means "match a single or partial word".
Review Comment:
Its not clear whether the "single-word" configuration item (detailed lower
down this documentation) which controls single word matches would also change
this partial-word matching.
##########
docs/user-manual/wildcard-syntax.adoc:
##########
@@ -44,7 +44,16 @@ But `news.*` would _not_ match:
* `news.europe.sport`
* `news.usa.sport`
-* `news.europe.politics.regional`
+
+The wildcard `news.eu*` would match:
+
+* `news.europe`
+
+But `news.*` would _not_ match:
+
+* `news.europe.sport`
+* `news.usa`
+* `news.usa.sport`
Review Comment:
Regardless of whether we should or shouldnt do partial matching (I've yet to
think on that)...this bit of documentation seems incorrect. Guessing the noted
address/other wildcard wasnt updated as intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
