gtully commented on code in PR #4744:
URL: https://github.com/apache/activemq-artemis/pull/4744#discussion_r1455371033
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -4322,7 +4322,9 @@ public QueueConfiguration getQueueConfiguration() {
.setTemporary(temporary)
.setInternal(internalQueue)
.setTransient(refCountForConsumers instanceof
TransientQueueManagerImpl)
- .setAutoCreated(autoCreated);
+ .setAutoCreated(autoCreated)
Review Comment:
hmm. I don't know whether the update needs to be smarter or every
QueueConfiguration must be fully defined. I think the update needs to be
smarter b/c there is a semantic meaning to null afaik.
I see another partial QueueConfiguration at
https://github.com/apache/activemq-artemis/blob/8c41fe67db3462790aed38f62fb4e4b1e55c3d49/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java#L695
there are a few in PostOfficeImpl. This suggests that the update logic needs
to check for the null. I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
