jbertram commented on code in PR #4744:
URL: https://github.com/apache/activemq-artemis/pull/4744#discussion_r1455886193
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -4322,7 +4322,9 @@ public QueueConfiguration getQueueConfiguration() {
.setTemporary(temporary)
.setInternal(internalQueue)
.setTransient(refCountForConsumers instanceof
TransientQueueManagerImpl)
- .setAutoCreated(autoCreated);
+ .setAutoCreated(autoCreated)
Review Comment:
Both things are true. The update needs to be smarter to not throw an NPE,
but `getQueueConfiguration` should also be setting all the relevant properties
on the `QueueConfiguration` it returns. In short, I think this is fine and we
can follow-up with another PR to deal with the update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
