AntonRoskvist commented on code in PR #4705:
URL: https://github.com/apache/activemq-artemis/pull/4705#discussion_r1465431024
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java:
##########
@@ -278,7 +279,12 @@ private void setupNotificationConsumer() throws Exception {
createPermissiveManagementNotificationToFilter() +
")");
- sessionConsumer.createQueue(new
QueueConfiguration(notifQueueName).setAddress(managementNotificationAddress).setFilterString(filter).setDurable(false).setTemporary(true));
+ sessionConsumer.createQueue(new QueueConfiguration(notifQueueName)
+
.setAddress(managementNotificationAddress)
+ .setFilterString(filter)
+ .setDurable(false)
+ .setTemporary(true)
+
.setRoutingType(RoutingType.MULTICAST));
Review Comment:
Semi related and making sure. I saw this issue presenting very consistently
on a broker cluster in a TEST environment. Turns out they had configured
default-routing-type = ANYCAST as an address setting and a match on "#" so that
the notifications got load balanced between brokers, sort of mimicking the
issue I'm going after with this PR.
I figured there ought to be no use case for setting up cluster notifications
with ANYCAST semantics so I added this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
