clebertsuconic commented on code in PR #4797:
URL: https://github.com/apache/activemq-artemis/pull/4797#discussion_r1474518475
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/federation/internal/FederationQueueEntry.java:
##########
@@ -28,19 +33,19 @@
* on a federation resource such that it is not torn down until all demand has
been
* removed from the local resource.
*/
-public class FederationConsumerEntry {
+public class FederationQueueEntry {
private final FederationConsumerInternal consumer;
- private int references = 1;
+ private final Set<String> consumerDemand = new HashSet<>();
Review Comment:
I was wondering why you didn't just use a HashSet of ServerConsumers here.
But I guess this is better since it decreases chances of memory leaking? if
you forgot an entry here at least you wouldn't leak the consumer->connection
and everything associated with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
