tabish121 commented on code in PR #4797:
URL: https://github.com/apache/activemq-artemis/pull/4797#discussion_r1474554919
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/federation/internal/FederationQueueEntry.java:
##########
@@ -28,19 +33,19 @@
* on a federation resource such that it is not torn down until all demand has
been
* removed from the local resource.
*/
-public class FederationConsumerEntry {
+public class FederationQueueEntry {
private final FederationConsumerInternal consumer;
- private int references = 1;
+ private final Set<String> consumerDemand = new HashSet<>();
Review Comment:
I wanted to avoid any chance of leaking the ServerConsumer instance which
have lead to holding onto other resources in the past. If the notification
isn't sent and we don't remove the demand at least we aren't holding onto the
actual consumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
