clebertsuconic commented on code in PR #4840: URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1512013812
########## artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPTunneledCoreLargeMessageReaderTest.java: ########## @@ -159,19 +169,18 @@ public void testReadMessageByteByByteFromDeliveryBuffer() throws Exception { when(receiver.recv()).thenReturn(deliveryAnnotations.duplicate().position(i - 1).limit(i).slice()); try { - assertNull(reader.readBytes(delivery)); + readMessage = null; + reader.readBytes(delivery); + Assert.assertNull(readMessage); } catch (IllegalStateException e) { fail("Should not throw as the reader should be able to read just delivery annotations."); } } - assertNotNull(reader.getDeliveryAnnotations()); - - final DeliveryAnnotations annotations = reader.getDeliveryAnnotations(); - - assertTrue(annotations.getValue().get(Symbol.valueOf("a")).equals("a")); - assertTrue(annotations.getValue().get(Symbol.valueOf("b")).equals("b")); - assertTrue(annotations.getValue().get(Symbol.valueOf("c")).equals("c")); + DeliveryAnnotations currentAnnotations = reader.getDeliveryAnnotations(); Review Comment: @tabish121 I remembered what happened.. I tried removing the open method by just the accept.. and I had made a mess back and forth until I stabilized on what you saw... thanks for the review.. I made the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org