gemmellr commented on code in PR #4840:
URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1513187210
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPTunneledCoreLargeMessageReader.java:
##########
@@ -209,13 +208,15 @@ public Message readBytes(Delivery delivery) throws
Exception {
state = State.DONE;
- return result;
- }
+ serverReceiver.onMessageComplete(delivery, result,
deliveryAnnotations);
- return null;
+ close();
Review Comment:
Doesnt feel like a reader should be closing itself. Was meant to be managed
by the interested party using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
