andytaylor commented on code in PR #2: URL: https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1579368288
########## artemis-console-war/pom.xml: ########## @@ -0,0 +1,111 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-console-project</artifactId> + <version>1.0.0-SNAPSHOT</version> + </parent> + + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-console-war</artifactId> + <packaging>war</packaging> + + + <name>ActiveMQ Artemis Console War</name> + + <dependencies> + <!-- mandatory core hawito modules --> + <dependency> + <groupId>io.hawt</groupId> + <artifactId>hawtio-system</artifactId> + </dependency> + + <!-- Servlet API is provided by the container --> + <dependency> + <groupId>jakarta.servlet</groupId> + <artifactId>jakarta.servlet-api</artifactId> + <scope>provided</scope> + </dependency> + + <!-- Logging --> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-api</artifactId> + </dependency> + </dependencies> + + <build> + <finalName>${project.artifactId}</finalName> + + <plugins> + + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-war-plugin</artifactId> + <configuration> + <nonFilteredFileExtensions> + <!-- default value contains jpg,jpeg,gif,bmp,png --> + <nonFilteredFileExtension>woff2</nonFilteredFileExtension> + <nonFilteredFileExtension>woff</nonFilteredFileExtension> + </nonFilteredFileExtensions> + <webResources> + <!-- Add the plugin build to web resources --> + <resource> + <filtering>true</filtering> + <directory>../artemis-console-extension/artemis-extension/build</directory> + <includes> + <include>**/*.*</include> + </includes> + <excludes> + <exclude>log4j.properties</exclude> + </excludes> + </resource> + </webResources> + </configuration> + </plugin> + + <plugin> + <groupId>org.eclipse.jetty</groupId> + <artifactId>jetty-maven-plugin</artifactId> + <version>${jetty-version}</version> Review Comment: It also omits logging from the webapp itself, I will add log4j which is what we use in Artemis and then remove it in Artemis, this will then default to the artemis logger and is consistent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
