gemmellr commented on code in PR #2: URL: https://github.com/apache/activemq-artemis-console/pull/2#discussion_r1586077228
########## artemis-console-extension/pom.xml: ########## @@ -0,0 +1,104 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-console-project</artifactId> + <version>1.0.0-SNAPSHOT</version> + </parent> + + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-console-extension</artifactId> + <packaging>pom</packaging> + + + <name>ActiveMQ Artemis Console</name> Review Comment: ActiveMQ Artemis Console Extension? ########## NOTICE: ########## @@ -0,0 +1,5 @@ +Apache ActiveMQ Artemis Console Plugin Review Comment: Drop the "Plugin" now ? ########## pom.xml: ########## @@ -0,0 +1,226 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>31</version> + <relativePath>org.apache:apache</relativePath> + </parent> + + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-console-project</artifactId> + <packaging>pom</packaging> + <version>1.0.0-SNAPSHOT</version> + + + <modules> + <module>artemis-console-extension</module> + <module>artemis-console-war</module> + <module>artemis-console-distribution</module> + </modules> + + <name>ActiveMQ Artemis Console Plugin</name> + <url>https://activemq.apache.org/components/artemis/</url> + + <properties> + <maven.compiler.source>11</maven.compiler.source> + <maven.compiler.target>11</maven.compiler.target> + <maven.compiler.release>11</maven.compiler.release> + <hawtio.version>4.0.0</hawtio.version> + <jakarta.servlet-api.version>5.0.0</jakarta.servlet-api.version> + <slf4j.version>2.0.12</slf4j.version> + <log4j.version>2.22.1</log4j.version> + <jetty-version>11.0.20</jetty-version> + <node-version>v20.9.0</node-version> + <yarn-version>v1.22.21</yarn-version> + <frontend-maven-plugin-version>1.15.0</frontend-maven-plugin-version> + <!-- Path to the Hawtio TypeScript plugin --> + <plugin.path>artemis-extension</plugin.path> + <project.build.outputTimestamp>2024-03-27T00:00:01Z</project.build.outputTimestamp> + </properties> + + <scm> + <connection>scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git</connection> + <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git</developerConnection> + <url>https://github.com/apache/activemq-artemis-console-plugin</url> Review Comment: Still needs updated to drop 'plugin' to reflect the renamed repo. ########## artemis-console-war/pom.xml: ########## @@ -0,0 +1,118 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-console-project</artifactId> + <version>1.0.0-SNAPSHOT</version> + </parent> + + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-console-war</artifactId> + <packaging>war</packaging> + + + <name>ActiveMQ Artemis Console War</name> + + <dependencies> + <!-- we need to depend on this for the build output --> + <dependency> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-console-extension</artifactId> + <type>pom</type> + <version>${project.version}</version> + </dependency> + <!-- mandatory core hawito modules --> + <dependency> + <groupId>io.hawt</groupId> + <artifactId>hawtio-system</artifactId> + </dependency> + + <!-- Servlet API is provided by the container --> + <dependency> + <groupId>jakarta.servlet</groupId> + <artifactId>jakarta.servlet-api</artifactId> + <scope>provided</scope> + </dependency> + + <!-- Logging --> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-api</artifactId> + <version>${slf4j.version}</version> + </dependency> + <dependency> + <groupId>org.apache.logging.log4j</groupId> + <artifactId>log4j-slf4j2-impl</artifactId> + <version>${log4j.version}</version> Review Comment: Should drop the versions and use the dependencyManagement from parent (need to add the log4j-slf4j2-impl dep there) ########## pom.xml: ########## @@ -0,0 +1,226 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>31</version> + <relativePath>org.apache:apache</relativePath> + </parent> + + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-console-project</artifactId> + <packaging>pom</packaging> + <version>1.0.0-SNAPSHOT</version> + + + <modules> + <module>artemis-console-extension</module> + <module>artemis-console-war</module> + <module>artemis-console-distribution</module> + </modules> + + <name>ActiveMQ Artemis Console Plugin</name> + <url>https://activemq.apache.org/components/artemis/</url> + + <properties> + <maven.compiler.source>11</maven.compiler.source> + <maven.compiler.target>11</maven.compiler.target> + <maven.compiler.release>11</maven.compiler.release> + <hawtio.version>4.0.0</hawtio.version> + <jakarta.servlet-api.version>5.0.0</jakarta.servlet-api.version> + <slf4j.version>2.0.12</slf4j.version> + <log4j.version>2.22.1</log4j.version> + <jetty-version>11.0.20</jetty-version> + <node-version>v20.9.0</node-version> + <yarn-version>v1.22.21</yarn-version> + <frontend-maven-plugin-version>1.15.0</frontend-maven-plugin-version> + <!-- Path to the Hawtio TypeScript plugin --> + <plugin.path>artemis-extension</plugin.path> + <project.build.outputTimestamp>2024-03-27T00:00:01Z</project.build.outputTimestamp> + </properties> + + <scm> + <connection>scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git</connection> + <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/activemq-artemis-console-plugin.git</developerConnection> + <url>https://github.com/apache/activemq-artemis-console-plugin</url> + <tag>HEAD</tag> + </scm> + + <issueManagement> + <system>JIRA</system> + <url>https://issues.apache.org/jira/browse/ARTEMIS</url> + </issueManagement> + + <developers> + <developer> + <name>The Apache ActiveMQ Team</name> + <email>d...@activemq.apache.org</email> + <url>http://activemq.apache.org</url> + <organization>Apache Software Foundation</organization> + <organizationUrl>http://apache.org/</organizationUrl> + </developer> + </developers> + <mailingLists> + <mailingList> + <name>User List</name> + <subscribe>users-subscr...@activemq.apache.org</subscribe> + <unsubscribe>users-unsubscr...@activemq.apache.org</unsubscribe> + <post>us...@activemq.apache.org</post> + </mailingList> + <mailingList> + <name>Development List</name> + <subscribe>dev-subscr...@activemq.apache.org</subscribe> + <unsubscribe>dev-unsubscr...@activemq.apache.org</unsubscribe> + <post>d...@activemq.apache.org</post> + </mailingList> + </mailingLists> + + <profiles> + <profile> + <id>release</id> + <build> + <plugins> + <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> + <executions> + <execution> + <phase>compile</phase> + <goals> + <goal>check</goal> + </goals> + </execution> + </executions> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + <executions> + <execution> + <phase>compile</phase> + <goals> + <goal>check</goal> + </goals> + </execution> + </executions> + </plugin> + </plugins> + </build> + </profile> + <!-- Override the apache-release profile from the parent to skip creating + a source-release archive here, it is done in artemis-console-distribution. --> + <profile> + <id>apache-release</id> + <build> + <plugins> + <plugin> + <artifactId>maven-assembly-plugin</artifactId> + <executions> + <execution> + <id>source-release-assembly</id> + <configuration> + <skipAssembly>true</skipAssembly> + </configuration> + </execution> + </executions> + </plugin> + </plugins> + </build> + </profile> + </profiles> + + <dependencyManagement> + <dependencies> + <!-- mandatory core hawtio modules --> + <dependency> + <groupId>io.hawt</groupId> + <artifactId>hawtio-system</artifactId> + <version>${hawtio.version}</version> + </dependency> + + <!-- Servlet API is provided by the container --> + <dependency> + <groupId>jakarta.servlet</groupId> + <artifactId>jakarta.servlet-api</artifactId> + <version>${jakarta.servlet-api.version}</version> + <scope>provided</scope> + </dependency> + + <!-- Logging --> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-api</artifactId> + <version>${slf4j.version}</version> + </dependency> + </dependencies> Review Comment: Should add the new log4j-slf4j2-impl dep here too. Might be worth managing the log4j version too, in case any of the other components ever uses it and maven potentially resolves a different version for them. E.g ``` <dependency> <groupId>org.apache.logging.log4j</groupId> <artifactId>log4j-slf4j2-impl</artifactId> <version>${log4j.version}</version> </dependency> <dependency> <groupId>org.apache.logging.log4j</groupId> <artifactId>log4j-api</artifactId> <version>${log4j.version}</version> </dependency> <dependency> <groupId>org.apache.logging.log4j</groupId> <artifactId>log4j-core</artifactId> <version>${log4j.version}</version> </dependency> ``` Or instead of the above you could import the log4j bom to manage them all (and everything else log4j) rather than define the specific deps here. ``` <dependency> <groupId>org.apache.logging.log4j</groupId> <artifactId>log4j-bom</artifactId> <version>${log4j.version}</version> <type>pom</type> <scope>import</scope> </dependency> ########## pom.xml: ########## @@ -0,0 +1,226 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>31</version> + <relativePath>org.apache:apache</relativePath> + </parent> + + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-console-project</artifactId> + <packaging>pom</packaging> + <version>1.0.0-SNAPSHOT</version> + + + <modules> + <module>artemis-console-extension</module> + <module>artemis-console-war</module> + <module>artemis-console-distribution</module> + </modules> + + <name>ActiveMQ Artemis Console Plugin</name> Review Comment: ActiveMQ Artemis Console Project ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
