tabish121 commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150593808
> > I don't really like the name "of" but that's just my personal taste probably... (of kind of kicks my OCD.. being a preposition, I feel like of what? :) > > but as I said.. that's my personal preference only... > > but I don't want to get in the way.. I will get used to it :) and I'm +1 to merge it.. and you should probably merge it soon before you have to rebase it. > > +1 from me. > > I presume it comes from the trend of Map.of(..) etc factory helpers. I dont mind it, though I personally wouldnt have changed it here given I'd rather SimpleString vanish, along with all the realted conversions and the byte doubling etc etc that come with it. Agreed with Robbie on the name, it matches some Collections APIs etc and isn't hard to grok plus its just less verbose. But I'd also like to see an effort towards removing the SimpleString to simplify working with the broker internals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
