gemmellr commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2151907691
The change should probably be rebased to current main, which has already added new use of the now-deprecated bits that this misses switching over. From doing a grep, there also looks to remain a number of other existing uses of toSimpleString that perhaps should be updated also. Feels like we should be unit testing any otherwise-unused deprecated bits, but it doesnt appear like either of the two SimpleStringTest classes do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
