gemmellr commented on code in PR #5149:
URL: https://github.com/apache/activemq-artemis/pull/5149#discussion_r1721703049
##########
artemis-distribution/pom.xml:
##########
@@ -117,16 +117,6 @@
<artifactId>artemis-console</artifactId>
<type>war</type>
</dependency>
- <dependency>
- <groupId>org.apache.activemq</groupId>
- <artifactId>activemq-branding</artifactId>
- <type>war</type>
- </dependency>
- <dependency>
- <groupId>org.apache.activemq</groupId>
- <artifactId>artemis-plugin</artifactId>
- <type>war</type>
- </dependency>
Review Comment:
This is as much a comment on the unaltered bit remaining, as the removals.
The binary distribution assembly has a number of entries in its LICENCE file
(and files it references) to do with covering the console bits. Those files
haven't been changed here, but it seems almost certain they will need to be.
That is, `artemis-distribution/src/main/resources/licenses/bin/LICENSE` and
files under dir
`artemis-distribution/src/main/resources/licenses/bin/licenses/`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
