gemmellr commented on PR #5149: URL: https://github.com/apache/activemq-artemis/pull/5149#issuecomment-2315593880
I added some commits fixing many of the code items I commented on earlier. I also switched it to the current SNAPSHOT since the staging repo was dropped when the vote was cancelled, so the build wouldn't work at all otherwise. Remaining open points are the licence stuff and other things discussed in the comments, e.g startup log messages / warnings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact