gemmellr commented on code in PR #5164:
URL: https://github.com/apache/activemq-artemis/pull/5164#discussion_r1731397321
##########
tests/soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/brokerConnection/mirror/ReplicatedBothNodesMirrorTest.java:
##########
@@ -249,33 +259,37 @@ private static void createMirroredBackupServer(String
serverName, int portOffset
brokerProperties.put("AMQPConnections.mirror.connectionElements.mirror.sync",
"false");
brokerProperties.put("largeMessageSync", "false");
- brokerProperties.put("addressSettings.#.maxSizeMessages", "1");
- brokerProperties.put("addressSettings.#.maxReadPageMessages", "2000");
- brokerProperties.put("addressSettings.#.maxReadPageBytes", "-1");
- brokerProperties.put("addressSettings.#.prefetchPageMessages", "500");
+ brokerProperties.put("mirrorAckManagerQueueAttempts", "5");
+ brokerProperties.put("mirrorAckManagerPageAttempts", "500000");
+ brokerProperties.put("mirrorAckManagerRetryDelay", "500");
+
// if we don't use pageTransactions we may eventually get a few
duplicates
brokerProperties.put("mirrorPageTransaction", "true");
- brokerProperties.put("mirrorReplicaSync", "false");
+
+ if (paging) {
+ brokerProperties.put("addressSettings.#.maxSizeMessages", "1");
+ brokerProperties.put("addressSettings.#.maxReadPageMessages", "2000");
+ brokerProperties.put("addressSettings.#.maxReadPageBytes", "-1");
+ brokerProperties.put("addressSettings.#.prefetchPageMessages", "500");
+ }
+
File brokerPropertiesFile = new File(serverLocation,
"broker.properties");
saveProperties(brokerProperties, brokerPropertiesFile);
File brokerXml = new File(serverLocation, "/etc/broker.xml");
assertTrue(brokerXml.exists());
- // Adding redistribution delay to broker configuration
- assertTrue(FileUtil.findReplace(brokerXml, "<address-setting
match=\"#\">", "<address-setting match=\"#\">\n\n" + "
<redistribution-delay>0</redistribution-delay> <!-- added by
SimpleMirrorSoakTest.java --> \n"));
- assertTrue(FileUtil.findReplace(brokerXml,
"<page-size-bytes>10M</page-size-bytes>",
"<page-size-bytes>100K</page-size-bytes>"));
if (TRACE_LOGS) {
replaceLogs(serverLocation);
}
}
- public static void createRealServers() throws Exception {
- createMirroredServer(DC1_NODE, "mirror", uriWithAlternate(DC2_IP,
DC2_BACKUP_IP), 0, true, uri(DC1_BACKUP_IP));
- createMirroredBackupServer(DC1_REPLICA_NODE, 1, uri(DC1_IP),
uriWithAlternate(DC2_IP, DC2_BACKUP_IP));
- createMirroredServer(DC2_NODE, "mirror", uriWithAlternate(DC1_IP,
DC1_BACKUP_IP), 2, true, uri(DC2_BACKUP_IP));
- createMirroredBackupServer(DC2_REPLICA_NODE, 3, uri(DC2_IP),
uriWithAlternate(DC1_IP, DC1_BACKUP_IP));
+ public static void createRealServers(boolean paging) throws Exception {
+ createMirroredServer(paging, DC1_NODE, "mirror",
uriWithAlternate(DC2_IP, DC2_BACKUP_IP), 0, true, uri(DC1_BACKUP_IP));
+ createMirroredBackupServer(paging, DC1_REPLICA_NODE, 1, uri(DC1_IP),
uriWithAlternate(DC2_IP, DC2_BACKUP_IP));
+ createMirroredServer(paging, DC2_NODE, "mirror",
uriWithAlternate(DC1_IP, DC1_BACKUP_IP), 2, true, uri(DC2_BACKUP_IP));
+ createMirroredBackupServer(paging ,DC2_REPLICA_NODE, 3, uri(DC2_IP),
uriWithAlternate(DC1_IP, DC1_BACKUP_IP));
Review Comment:
Checkstyle failure here with the "paging ," space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
