gemmellr commented on code in PR #5164:
URL: https://github.com/apache/activemq-artemis/pull/5164#discussion_r1731511829


##########
tests/soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/brokerConnection/mirror/ReplicatedBothNodesMirrorTest.java:
##########
@@ -213,15 +221,17 @@ private static void replaceLogs(File serverLocation) 
throws Exception {
                                       "logger.artemis_utils.level=INFO\n" + 
"\n" +
                                          
"logger.endpoint.name=org.apache.activemq.artemis.core.replication.ReplicationEndpoint\n"
 +
                                          "logger.endpoint.level=INFO\n" +
+                                         
"logger.ack.name=org.apache.activemq.artemis.protocol.amqp.connect.mirror.AckManager\n"
 +
+                                         "logger.ack.level=TRACE\n" +

Review Comment:
   Yep, I didnt mean it isnt something you would deliberately do when e.g 
dev/debugging, just that for the default execution of the test it would seem 
unusual. Especially since 'logging change alters behaviour' is a thing as ou 
noted; so we should test the more expected setup in the default case to cover 
what people are more likely to be doing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to