clebertsuconic commented on code in PR #5173:
URL: https://github.com/apache/activemq-artemis/pull/5173#discussion_r1732869601


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/replication/RepeatStartBackupTest.java:
##########
@@ -156,8 +171,110 @@ public void testLoopStart() throws Exception {
 
          Assertions.assertEquals(0, errors.get());
       }
+   }
+
+   @Test
+   public void testAckManagerRepetition() throws Exception {
+
+      String queueName = "queue_" + RandomUtil.randomString();
+
+      server.getConfiguration().setMirrorAckManagerQueueAttempts(300000);
+      server.getConfiguration().setMirrorAckManagerRetryDelay(1000);
+      backupServer.getConfiguration().setMirrorAckManagerPageAttempts(300000);
+      backupServer.getConfiguration().setMirrorAckManagerRetryDelay(1000);

Review Comment:
   @gemmellr I just wanted to make sure the records will never disappear. I add 
the records on the live broker... start a backup midway, and make sure that all 
the records made to the replica. (including the ones that were there before I 
started the replica).
   
   
   I was thinking about MAX_INT on the pageAttempts but I was afraid of 
overflows.. so I just used an arbitrary big number.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to