gemmellr commented on code in PR #5173: URL: https://github.com/apache/activemq-artemis/pull/5173#discussion_r1733260591
########## tests/soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/brokerConnection/mirror/ReplicatedBothNodesMirrorTest.java: ########## @@ -22,6 +22,7 @@ import javax.jms.JMSException; import javax.jms.MessageConsumer; import javax.jms.MessageProducer; +import javax.jms.Queue; Review Comment: Some of them aren't from this test, but some clearly are for this test (look at the end, immediately after the truncation, for >100 lines for this specific test ). You cant see the majority because of the log truncation. What can be said is that its failing by multiple thousands of files (expecting <4k, got almost 8k), there arent nearly that many test classes, it didnt fail before this change, but does after, and the test [method] failing every time is one you are changing in a way that causes increased file usage. That failure isnt unrelated to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
