gemmellr commented on PR #5172: URL: https://github.com/apache/activemq-artemis/pull/5172#issuecomment-2318219393
> @gemmellr I am sorry, I think I have wasted your time here: > > This consistency level that I'm implementing here has already been used before, see: > > https://github.com/apache/activemq-artemis/blob/7ca30e9a638e5192bfbe135585e5df9185b73cd7/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java#L408-L416 > > I guess this PR is a red herring from the fact I was : I - missing acks after replication, II - the retries were not effective > > I will keep the tweaks done in this PR... I will not touch OperationContextImpl as that's a very hot class. I will keep the comments only. I'm not following this comment or the changes. This bit of code is for the mirror Source handling, whilst the previous changes were squarely aimed at the Target operation handling? So it seems like the origin broker has always had an advantage which would exacerbate the issue you were trying to address? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
