gemmellr commented on code in PR #5172:
URL: https://github.com/apache/activemq-artemis/pull/5172#discussion_r1736648838
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AckManager.java:
##########
@@ -139,7 +140,14 @@ public void endRetry() {
// schedule a retry
if (!sortRetries().isEmpty()) {
- scheduledComponent.delay();
+ ActiveMQScheduledComponent scheduleComponentReference =
scheduledComponent;
+ if (scheduleComponentReference != null) {
+ try {
+ scheduleComponentReference.delay();
+ } catch (RejectedExecutionException thatsOK) {
+ logger.debug("Could not schedule an execution - {}",
thatsOK.getMessage(), thatsOK);
Review Comment:
```suggestion
logger.debug("Could not schedule AckManager retry task - {}",
thatsOK.getMessage(), thatsOK);
```
So that the message conveys _what_ didnt happen, otherwise I'd still need to
open the code.
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java:
##########
@@ -377,6 +428,30 @@ public String toString() {
}
}
+
+ static final class IgnoreReplicationTaskHolder {
+ @Override
+ public String toString() {
+ return "TaskHolder [storeLined=" + storeLined +
Review Comment:
I think you have unwound some fixups from earlier, this is back..or did I
imagine you fixing it already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
