gemmellr commented on PR #5288: URL: https://github.com/apache/activemq-artemis/pull/5288#issuecomment-2402591679
> @gemmellr I went a further step and I'm never starting a target serverB. I wouldnt call that further personally. It proves the prior test wasnt vetting the mirror behaviour sufficiently, but still means the test still doesnt really verify the messages that are meant to be mirrored, are. It never even inspects the SnF queue now at all. For all it knows, the messages could have been discarded at expiration rather than routed to the expiry queue, and just as with the previous version of the test it wouldnt notice they are not mirrored like they should be. I'm assuming it did fail before the fix, so it was useful to verify the fix made a difference, but that doenst really make it a good test of the key behaviour such that the issue doesnt come back in some form. Verifying the actual mirror behaviour with the peer would. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
