gemmellr commented on PR #5288: URL: https://github.com/apache/activemq-artemis/pull/5288#issuecomment-2402620940
I don't see it touching the SnF queue at all, can you point me to it? I do see it looking at the expiry queue and checking X messages expire. X messages that were in the origin queue. My point is that for all the test knows, I break the mirroring again 5 minutes after it i merged, such that we do expire SnF queue messages again, but only such that they get _discarded_ rather than routed to the expiry queue. That test will not notice that and so will still pass, but as a test specifically verifying the mirroring isnt expiring SnF queue messages it really should fail. Setting up a peer to verify the actual mirroring, verifies that it actually does what we expect. That will absolutely notice when it doesnt do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
