jbertram commented on code in PR #5290:
URL: https://github.com/apache/activemq-artemis/pull/5290#discussion_r1797031413
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataExporter.java:
##########
@@ -80,6 +80,12 @@ public final class XmlDataExporter extends DBOption {
private XMLStreamWriter xmlWriter;
+ private Throwable lastError;
+
+ // I am creating a hidden feature now, in case users ever ask to expose
this, it would be already here.
+ @Option(names = "undefined-prefix", hidden = true, description = "In case a
queue does not exist, this will define the prefix to be used on the message
export.")
Review Comment:
Well, I think it makes sense, and I also think it's worth a full explanation
of the use-case in the documentation (which I plan on writing after this is
merged).
I wouldn't change the handling if there's just one queue missing. That's
just more complexity to explain & maintain without much real benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
