clebertsuconic commented on code in PR #5290:
URL: https://github.com/apache/activemq-artemis/pull/5290#discussion_r1797213503


##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataExporter.java:
##########
@@ -80,6 +80,12 @@ public final class XmlDataExporter extends DBOption {
 
    private XMLStreamWriter xmlWriter;
 
+   private Throwable lastError;
+
+   // I am creating a hidden feature now, in case users ever ask to expose 
this, it would be already here.
+   @Option(names = "undefined-prefix", hidden = true, description = "In case a 
queue does not exist, this will define the prefix to be used on the message 
export.")

Review Comment:
   @jbertram I don't think we should make this an use-case.. users are not 
really supposed to remove the queues...
   
   
   what I'm doing this is just not failing an export/import in case it ever 
happened.. say after a recovered data for instance.
   
   
   BTW: I'm not going to change the handling of the prefix... a manual undelete 
will be good enough I think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to