tabish121 commented on PR #5346:
URL: 
https://github.com/apache/activemq-artemis/pull/5346#issuecomment-2479905026

   There is at least one race in the AMQPLargeMessageReader where the bytes 
being written to the large message file is done on a session thread and only 
when the message is complete is it submitted to the receiver via the connection 
thread.  If a network error happens that causes the receiver to close its 
active reader (which deletes the large message file) and at the same time the 
processing of a large message is about to complete and schedule the 
'onMessageComplete' call to process the read message the message will get 
processed after its file is deleted and be put onto the Queue as if it was 
valid resulting in a corrupted message.  
   
   We need to reevaluate the logic and how we process AMQP large messages off 
the netty thread to better account for the chasing scenarios to ensure files 
are deleted but completed message still get processed as intended.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to