clebertsuconic commented on code in PR #5346:
URL: https://github.com/apache/activemq-artemis/pull/5346#discussion_r1843001292
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonAbstractReceiver.java:
##########
@@ -346,6 +346,7 @@ public void onMessageComplete(Delivery delivery,
connection.requireInHandler();
try {
+ this.messageReader.close();
Review Comment:
the issue is actually the call to actualDelivery ...if we perform
actualDelivery before calling messageReader.close() you could have the message
being part of the queue while the reader will be marked as open. a connection
failure happens and the body of the message removed. as a consequence the
client will receive an empty body message which the server is translating as a
bytesMessage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
