kenliao94 commented on code in PR #1354:
URL: https://github.com/apache/activemq/pull/1354#discussion_r1848558266
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/policy/DeadLetterStrategy.java:
##########
@@ -60,6 +71,16 @@ public interface DeadLetterStrategy {
*/
public void setProcessNonPersistent(boolean processNonPersistent);
+ /**
+ * @return the PreserveDeliveryMode
Review Comment:
Ah, I guess just the name is a bit confusing to me. Because it starts with
"is" and return a boolean, if it returns the PreserveDeliveryMode it should be
"get" imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
