pa-deasy commented on PR #1354: URL: https://github.com/apache/activemq/pull/1354#issuecomment-2499298548
> @pa-deasy I assume the code that actually calls "setPreserveDeliveryMode" which is read from destination configuration will come later? Yes that should be straightforward. I just wanted feedback on the `RegionBroker` and DeadLetterStrategy` for the draft. Thanks folks for your feedback on "move dead letter queue message preparation logic to the AbstractDeadLetterStrategy class". Those are great points. I will update my PR appropriately and add tests. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
