mattrpav commented on code in PR #1352:
URL: https://github.com/apache/activemq/pull/1352#discussion_r1864047656
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -184,6 +184,7 @@ public class BrokerService implements Service {
private JmsConnector[] jmsBridgeConnectors; // these are Jms to Jms bridges
// to other jms messaging systems
private boolean deleteAllMessagesOnStartup;
+ private boolean deleteAllScheduledMessagesOnStartup = false;
Review Comment:
Scheduled message support is part of the JMS 3.1/2.0 spec. I'm not loving
the separate config flag. We don't have a
'deleteAllDurableTopicMessagesOnStartup' flag. It is 'all' messages on startup.
I'm thinking it would be better to have a flag to have the scheduler
_ignore_ the deleteAllMessagesOnStartup.
Possible path forward:
v6.x - Scheduler ignores deleteAllMessagesOnStartup by default (to maintain
existing behavior)
v7.x - Scheduler honors deleteAllMessagesOnStartup by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
