kenliao94 commented on code in PR #1352:
URL: https://github.com/apache/activemq/pull/1352#discussion_r1865257087


##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -184,6 +184,7 @@ public class BrokerService implements Service {
     private JmsConnector[] jmsBridgeConnectors; // these are Jms to Jms bridges
     // to other jms messaging systems
     private boolean deleteAllMessagesOnStartup;
+    private boolean deleteAllScheduledMessagesOnStartup = false;

Review Comment:
   I see where you are coming from. Initially I would expect 
deleteAllMessagesOnStartup will include scheduled messages. I even opened a 
Jira ticket on it. 
https://issues.apache.org/jira/projects/AMQ/issues/AMQ-9572?filter=allissues 
from @jbonofre feedback we should have a separated flag for scheduled messages.
   
   Regarding the proposal in v7.x I think if we have the consensus that 
deleteAllMessagesOnStartup should include scheduled messages then it makes 
sense to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to