kenliao94 commented on code in PR #1354: URL: https://github.com/apache/activemq/pull/1354#discussion_r1855337759
########## activemq-broker/src/main/java/org/apache/activemq/broker/region/policy/AbstractDeadLetterStrategy.java: ########## @@ -91,6 +129,14 @@ public void setProcessNonPersistent(boolean processNonPersistent) { this.processNonPersistent = processNonPersistent; } + @Override + public boolean isPreserveDeliveryMode() { return this.preserveDeliveryMode; } Review Comment: It should have the same format as other getter for consistency. So return at new new line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact