gemmellr commented on code in PR #5386:
URL: https://github.com/apache/activemq-artemis/pull/5386#discussion_r1875697730
##########
pom.xml:
##########
@@ -79,8 +79,8 @@
<properties>
<maven.compiler.source>11</maven.compiler.source>
- <maven.compiler.target>11</maven.compiler.target>
- <maven.compiler.release>11</maven.compiler.release>
+ <maven.compiler.target>17</maven.compiler.target>
+ <maven.compiler.release>17</maven.compiler.release>
Review Comment:
Why not changing the source level too?
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSClientTestSupport.java:
##########
@@ -223,13 +217,7 @@ protected String getBrokerOpenWireJMSConnectionString() {
try {
int port = AMQP_PORT;
- String uri = null;
-
- if (isUseSSL()) {
- uri = "tcp://127.0.0.1:" + port;
- } else {
- uri = "tcp://127.0.0.1:" + port;
- }
Review Comment:
Same here.
##########
.github/dependabot.yml:
##########
@@ -20,14 +20,6 @@ updates:
schedule:
interval: "daily"
ignore:
- # Ignore all these until we move to JDK >= 17
- - dependency-name: 'org.apache.derby:*'
- versions: '>= 10.16'
Review Comment:
Derby 10.17 requires Java 21 so you might want to just update the comment
and version for this and leave in place rather than remove it entirely, or the
bot will presumably just raise a PR that wont work?
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSClientTestSupport.java:
##########
@@ -174,13 +174,7 @@ protected String getBrokerCoreJMSConnectionString() {
try {
int port = AMQP_PORT;
- String uri = null;
-
- if (isUseSSL()) {
- uri = "tcp://127.0.0.1:" + port;
- } else {
- uri = "tcp://127.0.0.1:" + port;
- }
Review Comment:
I assume ErrorProne was complaining that the two legs are the same, and it
would be right to. Presumably there are no tests that actually needed / have
hit this not being implemented yet, but rather than just remove the logic like
this I think it should be left and instead made to throw e.g
UnsupportedOperationException / IllegalStateException, so that if anyone later
finds themselves in the position of calling this in that situation it is
immediately obvious why it wont work and what needs implemented.
##########
docs/user-manual/versions.adoc:
##########
@@ -12,6 +12,26 @@ NOTE: If the upgrade spans multiple versions then the steps
from *each* version
NOTE: Follow the general upgrade procedure outlined in the
xref:upgrading.adoc#upgrading-the-broker[Upgrading the Broker] chapter in
addition to any version-specific upgrade instructions outlined here.
+== 2.39.0
+
+https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12355167[Full
release notes]
+
+=== Highlights
+
+* *Java 17 is now required.*
+
+=== Upgrading from 2.38.0
+
+* Due to https://issues.apache.org/jira/browse/ARTEMIS-5202[ARTEMIS-5202]
*support for Java 11 has been dropped*.
++
+The main reason for this change is that the version of Jetty we were embedding
in previous versions (i.e. 10)
https://github.com/jetty/jetty.project/issues/10485[will officially reach its
end-of-life on January 1, 2025] and will therefore no longer be receiving _any_
fixes - including security fixes.
+Security is critical for us and most of our users so we therefore need to
upgrade to Jetty 12 - the only version of Jetty now supported.
+Jetty 12 requires Java 17 so the difficult decision was made to drop support
for Java 11.
++
+Java 11 is quite old at this point and some vendors have already dropped
support for it so many (if not most) users have already upgraded to Java 17.
For those that haven't we apologize for any inconvenience.
Review Comment:
This feels unnecessarily wordy. Personally, I'd drop everything after "Jetty
12 requires Java 17" .
I don't think it was really a difficult decision given the immediately prior
reasoning, and I dont see need to justify it so lengthily in the versions doc.
Especially given how many projects have moved already, up to >2 years ago. For
me the rest of this mainly just distracts from the more actually noteworthy
detail coming after this about client compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
