gemmellr commented on code in PR #5386:
URL: https://github.com/apache/activemq-artemis/pull/5386#discussion_r1876142582
##########
artemis-website/pom.xml:
##########
@@ -91,7 +91,7 @@
</goals>
<configuration>
<doctitle>ActiveMQ Artemis ${project.version}
API</doctitle>
- <source>11</source>
+ <source>${maven.compiler.source}</source>
Review Comment:
This is already the default, would be better off just deleting the config.
##########
pom.xml:
##########
@@ -79,8 +79,8 @@
<properties>
<maven.compiler.source>11</maven.compiler.source>
- <maven.compiler.target>11</maven.compiler.target>
- <maven.compiler.release>11</maven.compiler.release>
+ <maven.compiler.target>17</maven.compiler.target>
+ <maven.compiler.release>17</maven.compiler.release>
Review Comment:
Ok to hold off to 3.0.0 I guess, though in general I'd just be updating it
at the same time as the others.
Dont forget the other features from 12-16 such as Records etc. (BTW 'Pattern
matching for switch' in 17 was a preview; there was 'expressions in switch'
from 14, or 'patterns in instanceof' from 16).
I think Classic is mainly doing that because changing it causes compile
failures in the existing source. Since we are using maven.compiler.release 17
in this case (meaning it compiles with the 17 signatures regardless), which
classic is not, I'm not sure there is the same scope for compile failure here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
